fix: strip npx/bunx/pnpm prefixes in lint linter detection#366
Merged
pszymkowiak merged 1 commit intomasterfrom Mar 6, 2026
Merged
fix: strip npx/bunx/pnpm prefixes in lint linter detection#366pszymkowiak merged 1 commit intomasterfrom
pszymkowiak merged 1 commit intomasterfrom
Conversation
When running `rtk lint npx eslint ...`, args[0] was "npx" instead of "eslint", causing no JSON format flag injection and duplicated output. Extract strip_pm_prefix() and detect_linter() helpers, skip package manager prefixes before identifying the actual linter name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk lint npx eslint ...was detectingnpxas the linter name instead ofeslint-f jsonflag injection, falling back to text parsing with duplicated diagnostics and wrong countsFix
strip_pm_prefix()to skipnpx,bunx,pnpm,pnpm exec,yarnprefixesdetect_linter()to identify linter name from effective argseffective_args(without PM prefix)Test plan
strip_pm_prefixanddetect_lintercargo fmtclean,cargo clippycleanFixes #186