fix: support git commit -am, --amend and other flags (#327)#360
Merged
pszymkowiak merged 1 commit intomasterfrom Mar 6, 2026
Merged
fix: support git commit -am, --amend and other flags (#327)#360pszymkowiak merged 1 commit intomasterfrom
pszymkowiak merged 1 commit intomasterfrom
Conversation
Clap was rejecting -a, --amend, --allow-empty etc. because Commit only declared -m/--message. Switch to trailing_var_arg like other git subcommands so all flags pass through to git directly. Fixes #327
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk git commit -am "msg"crashed witherror: unexpected argument '-a' found-m/--message, rejecting all other git commit flagstrailing_var_arg + allow_hyphen_values(same pattern as Add, Push, Pull)What changed
GitCommands::Commitnow takes rawargs: Vec<String>instead ofmessage: Vec<String>build_commit_commandpasses args directly to git instead of wrapping with-m-a,-am,--amend,--allow-empty,--no-edit, etc.Tests
-am,--amend, single message, multiple messages (updated)-am,-m,--amend --no-editall produce correct outputFixes #327
🤖 Generated with Claude Code