Add automatic status to color mapping#68
Add automatic status to color mapping#68mrrobot47 merged 1 commit intortCamp:masterfrom lukasz-mitka:master
Conversation
|
Hey @lukaszmitka-aptiv, thanks for the PR! Till this PR is tested and approved, you can use something similar to this as well: SLACK_COLOR: "${{ job.status == 'success' && 'good' || 'danger' }}" |
|
Hey @mrrobot47, thanks. but it's just horrible. |
|
I agree 😄 I am running a little busy so will check this in the weekend mostly. |
|
Just want to say I like the PR's goal, but I think the documentation should still include an example where the color is explicitly specified. So maybe the sample YAML in the README.md could contain a comment: SLACK_COLOR: ${{ job.status }} # or a specific color like 'green' or '#ff00ff'Also, maybe the README could document the new color mapping: |
While I agree, I don't have time right now to do it. |
|
@lukaszmitka-aptiv I will update the readme. No need to worry about that. |
|
@mrrobot47 @JuriBurakov are you guys going to merge this anytime soon? |
|
Tested and LGTM 🎉 |
|
@lukasz-mitka This has been released in https://github.com/rtCamp/action-slack-notify/releases/tag/v2.1.3. |
No description provided.