fix: add version check to enforce Node.js >= 20#62
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial compatibility safeguard by adding a runtime Node.js version check, ensuring the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0287ff39cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Code Review
This pull request adds a runtime check to enforce the minimum Node.js version. The implementation in src/color.ts has a flaw where it incorrectly allows older, unsupported Node.js versions to pass the check due to using feature detection that is too broad. I've suggested a more robust implementation that correctly checks the Node.js major version. Additionally, the PR description is inconsistent with the code's handling of Bun and Deno, which you may want to correct.
There was a problem hiding this comment.
Pull request overview
Adds a runtime guard to prevent rslog from being used on unsupported runtimes / Node.js versions, and updates the documentation to reflect the new minimum supported Node range.
Changes:
- Add an import-time runtime check in
src/color.tsintended to enforce supported Node.js versions (and disallow Bun/Deno per PR description). - Switch color styling implementation to reference
util.styleTextvia thenode:utilmodule object. - Update README to document the supported Node.js semver range.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/color.ts |
Introduces an import-time environment/version guard and updates styleText usage to util.styleText. |
README.md |
Documents the new supported Node.js range in Install/Environment sections. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added a runtime check to throw an error if the Node.js version is unsupported, ensuring the package is only used in compatible environments.