fix: avoid import { logger } from '@rsbuild/core'#41
Merged
chenjiahan merged 1 commit intorstackjs:mainfrom Nov 27, 2025
Merged
fix: avoid import { logger } from '@rsbuild/core'#41chenjiahan merged 1 commit intorstackjs:mainfrom
import { logger } from '@rsbuild/core'#41chenjiahan merged 1 commit intorstackjs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
@rsbuild/coreis set as an optional peerDependency of this plugin.However, there is
import { logger } from '@rsbuild/core'in the output which would make@rsbuild/corea required peerDependency.This would result in having error when using this plugin in a non-Rsbuild project (e.g.: an Rspeedy project) with strict dependencies installation (Yarn Plug'n'Play or Pnpm
enableGlobalVirtualStore)In this patch, we use
api.loggerand fallback toconsolefor old version of Rsbuild.