Skip to content

fix: lint dirty modules#5

Merged
LingyuCoder merged 2 commits intomasterfrom
fix/lint-dirty-modules-only
Sep 26, 2024
Merged

fix: lint dirty modules#5
LingyuCoder merged 2 commits intomasterfrom
fix/lint-dirty-modules-only

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Use compilation.builtModules to collect changed modules when lintOnlyDirtyModules is enabled

Breaking Changes

Additional Info

@LingyuCoder LingyuCoder requested a review from 9aoy September 26, 2024 09:55
@LingyuCoder
Copy link
Copy Markdown
Contributor Author

Should upgrade dependencies with security issue, I will do it in another pr

@LingyuCoder LingyuCoder merged commit 1245191 into master Sep 26, 2024
@LingyuCoder LingyuCoder deleted the fix/lint-dirty-modules-only branch September 26, 2024 10:15
@markmssd
Copy link
Copy Markdown

I've tested it and seems to be working now, with Rspack v1.0.8 🎉 It has the exact behaviour as Webpack now, thanks! When do you think we can have a new release of this plugin?

@LingyuCoder
Copy link
Copy Markdown
Contributor Author

I've tested it and seems to be working now, with Rspack v1.0.8 🎉 It has the exact behaviour as Webpack now, thanks! When do you think we can have a new release of this plugin?

Published v4.2.1, please have a try 😊

@nanianlisao
Copy link
Copy Markdown

@LingyuCoder @9aoy
Can compatibility with rspack0.x be added? Only rspack 1.0 supports the seal hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants