fix: skipping inside arrays on comma-atomic#757
Merged
Conversation
Tail skipping was not triggered when the item matching the unitary transition was an atomic value inside a list. For example, selecting `$[0]` from a long list of integers would never skip, massively degrading performance. Skipping was added to `handle_comma` in the same vein as it was in `handle_colon` to enable this. Ref: #751
This addresses a hard-to-repro bug where reclassification being called with an index at the end of a block would break the classifier.
KraftRicardo
previously approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Tail skipping was not triggered when the item matching the unitary transition was an atomic value inside a list. For example, selecting
$[0]from a long list of integers would never skip, massively degrading performance.Skipping was added to
handle_commain the same vein as it was inhandle_colonto enable this.Issue
Resolves: #751
Checklist
All of these should be ticked off before you submit the PR.
just verifylocally and it succeeded.