Skip to content

fix: atomic values getting invalid spans#327

Merged
V0ldek merged 4 commits intomainfrom
v0ldek/#22-e2e-proptests
Oct 21, 2023
Merged

fix: atomic values getting invalid spans#327
V0ldek merged 4 commits intomainfrom
v0ldek/#22-e2e-proptests

Conversation

@V0ldek
Copy link
Member

@V0ldek V0ldek commented Oct 21, 2023

Short description

Fixed an issue where atomic values would be matched with all trailing characters up until the next closing.
See the long_number test for a reproduction on v0.8.3.

Issue

This was detected with a prototype of proptests for #22.

Checklist

All of these should be ticked off before you submit the PR.

  • I ran just verify locally and it succeeded.
  • Issue was given go ahead and is linked above OR I have included justification for a minor change.
  • Unit tests for my changes are included OR no functionality was changed.

- Fixed an issue where atomic values would be matched with all
trailing characters up until the next closing.
@V0ldek V0ldek merged commit 8ebde5c into main Oct 21, 2023
@V0ldek V0ldek deleted the v0ldek/#22-e2e-proptests branch October 21, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant