Merged
Conversation
Owner
|
Just tried this out in a few apps and it seems to work perfectly. Nice work! 💯 |
Owner
|
Just released v3.5 containing these changes. |
3 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My comment at #145 (comment) details several issues in the vertical metrics of Inter.
This PR solves these, plus another issue I uncovered along the way.
The approach that ended up working well:
true(not sure how critical this is, but it probably doesn’t hurt, because Google Fonts checks for this)Results
Text is nicely vertically-aligned in containers:
Default line height is within the range of comparable fonts:
All bounding boxes are consistent height between styles in the variable font:
Caveat
I'm not 100% sure how this will render in Windows. As far as I know, some double-stacking accents will be partially cutoff, some of the time on Windows. It's possible we can fix this by increasing the
winAscentvalue, but I think we should prioritize how this impacts general UI usage above how Windows displays certain accents.Another issue that this avoids
As I was experimenting, I found that bounding boxes were different, depending on the content of the text (at least in Sketch – I didn't do comprehensive tests). Not good! This was solved by the overshooting ascender & descender values, plus by setting alignment zones at these values.