Disable virtual parent optimization on <head>#827
Closed
eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
Closed
Disable virtual parent optimization on <head>#827eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
Conversation
…estroying already applied styles during <head> mutations
87f303c to
9949db9
Compare
…ent a new parent from using virtual parent, then any new children get lost
Contributor
Author
|
Re. b27789e I managed to patch over the failing test by also cancelling the virtual parent optimization for subsequent adds if any or under ... however I didn't figure out why exactly it wasn't working, and the solution in b27789e is likely brittle. Hopefully this is okay as the virtual parent optimization is slated for removal. |
Contributor
Author
|
OK so I couldn't create a test in order to recreate this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was experiencing an issue where the virtual parent optimization was destroying already applied styles during mutations