Conversation
Juice10
approved these changes
Feb 4, 2022
Member
Juice10
left a comment
There was a problem hiding this comment.
This is great! So much cleaner, less repetitive and much easier to add something without having to change it in 4 or 5 places. Well done!
This was referenced Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does not have any functional change to the library, just a code refactoring to the rrweb's observer module.
Previously, we are repeating the type of parameters many times across the code base, after the refactoring, most parameters are using the same interface.
Also, we are changing the function parameters from multiple arguments into a single object argument and using destructing to access the properties, which reduces the mistakes of passing arguments with the same type in the wrong order.