Record and replay nested stylesheet rules#665
Closed
Juice10 wants to merge 3 commits intorrweb-io:masterfrom
Closed
Record and replay nested stylesheet rules#665Juice10 wants to merge 3 commits intorrweb-io:masterfrom
Juice10 wants to merge 3 commits intorrweb-io:masterfrom
Conversation
Member
|
@Juice10 Nice work! There are some small TS types that need an update to pass the CI. |
Member
|
picked in #666 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS can have nested rules thanks to @media queries and other at rules.
It is even possible to nest media queries in media queries, I tried it a couple levels and haven't found a limit.
It seems like https://stitches.dev uses mutations to @media rules quite heavily which means that currently recordings of sites built with Stitches feel very broken.
This pr add support for mutations to those nested rules.