Don't rebuildFullSnapshot if it's the first run#532
Merged
Yuyz0112 merged 2 commits intorrweb-io:masterfrom Apr 9, 2021
Merged
Don't rebuildFullSnapshot if it's the first run#532Yuyz0112 merged 2 commits intorrweb-io:masterfrom
Yuyz0112 merged 2 commits intorrweb-io:masterfrom
Conversation
Contributor
Author
|
@Yuyz0112 Could you take a look when you can? |
Yuyz0112
reviewed
Apr 8, 2021
| case EventType.FullSnapshot: | ||
| castFn = () => { | ||
| // Don't build a full snapshot during the first play through since we've already built it when the player was mounted. | ||
| if (this.firstPlay) { |
Member
There was a problem hiding this comment.
where do we set firstPlay to truthy?
Contributor
Author
There was a problem hiding this comment.
Whoops, fixed the typo. It's initialized to true at first.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 I don't think we need to rebuild the full snapshot during the first play-through since we already do it when we initialize the player.
Before:
rebuildFullSnapshotwhile initializing the playerrebuildFullSnapshotwhile processing theFullSnapshoteventAfter:
rebuildFullSnapshotwhile initializing the player