fix: don't bundle everything into console recorder#1594
fix: don't bundle everything into console recorder#1594pauldambra wants to merge 19 commits intorrweb-io:masterfrom PostHog:fix/console-bundle-size
Conversation
🦋 Changeset detectedLatest commit: 9592411 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -1,7 +1,7 @@ | |||
| import type { listenerHandler, RecordPlugin, IWindow } from '@rrweb/types'; | |||
| import { utils } from 'rrweb'; | |||
There was a problem hiding this comment.
this is the fix here... this line was including the whole of rrweb
Juice10
left a comment
There was a problem hiding this comment.
This looks really good @pauldambra, I had a couple tweaks, mainly due to the release of rrweb 2.0.0-alpha.18
But as soon as they are tackled we can merge this one and do another release.
FYI: You might have to pull in master to fix the tests, after adding the suggestions.
Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
Co-authored-by: Justin Halsall <Juice10@users.noreply.github.com>
|
yuck, I tried to be clever and as always that backfired... i'll recreate this PR from a person fork 🫠 |
the use of
utils.patchfromrrwebin theconsoleplugin was including the whole of rrweb in the console recorder.move the patch function into the existing
@rrweb/utilspackage fixes this(I've only proven the bundle is fixed - i'm hoping CI proves the recorder still works 😅 )
just looking at bundle size this reduces the console recorder plugin from 255kb to 15kb