Avoid the costly createElement calls during snapshot#1434
Closed
eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
Closed
Avoid the costly createElement calls during snapshot#1434eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
eoghanmurray wants to merge 2 commits intorrweb-io:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 7b2d101 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
YunFeng0817
approved these changes
Mar 29, 2024
Member
YunFeng0817
left a comment
There was a problem hiding this comment.
Thank you for facilitating this great pull request!
Contributor
|
This version looks slower than my version and even the original version:
Benchmark: https://jsbench.me/ktlqztuf95/2 |
Contributor
Author
|
Thanks @H4ad I had been focusing on the correctness and assumed the perf. improvement, so will close this in favour of the original. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative PR to #1387
I've also renamed
getHreftogetHrefWithoutHashto better reflect what it is doing