⚠️ No Changeset found

Latest commit: 724d805

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

See my comments in #1301

Ignoring the current failing tests which are related to _cssText which is presumably unrelated, this PR really needs a few exemplifying test cases to ensure there isn't a future regression on this (it looks like there was a few prior rounds of changes around this issue in the git history). Would you be able to supply that or would you prefer to wait until I can figure it out?

I imagine we'd want to add a <textarea> one of the test cases in packages/rrweb/test/record.test.ts in order to show that the repeated value is a problem.

As currently implemented, this PR modifies the tests as follows:

rrweb-snapshot:test:     -         <textarea name="" id="" cols="30" rows="10">1234</textarea>
rrweb-snapshot:test:     +         <textarea name="" id="" cols="30" rows="10" value="1234"></textarea>

This is less correct in that if the latter is rendered in HTML, then the value attribute is ignored (the .value parameter is available in javascript)

I'm gonna close this one as #1351 goes into much more detail than this one by fixing at recording time, but also fixing for existing recordings where the bad data is already in the event (like this fix does)

Forgot to say: thank you for this PR, I wouldn't have made my one if I could not see your intended changes!