Skip to content

Perf: don't run the regex replace unless the selectorText contains a colon#1280

Merged
eoghanmurray merged 8 commits intorrweb-io:masterfrom
eoghanmurray:fixSafariColons
Aug 14, 2023
Merged

Perf: don't run the regex replace unless the selectorText contains a colon#1280
eoghanmurray merged 8 commits intorrweb-io:masterfrom
eoghanmurray:fixSafariColons

Conversation

@eoghanmurray
Copy link
Contributor

@eoghanmurray eoghanmurray commented Aug 8, 2023

(rules generally contain colons)

This is an imagined performance improvement on #1253 so should be measured!

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2e26050

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eoghanmurray eoghanmurray mentioned this pull request Aug 8, 2023
Merged
@eoghanmurray eoghanmurray force-pushed the fixSafariColons branch 3 times, most recently from 0ea58e7 to c7a0776 Compare August 8, 2023 16:31
eoghanmurray
eoghanmurray commented Aug 9, 2023
View reviewed changes
@mydea
Copy link
Contributor

mydea commented Aug 9, 2023

Looks good to me - I also had a hard time testing this locally, but this should be good I think (don't have any setup right now to verify this, but the existing test should cover this hopefully?)

@eoghanmurray
Copy link
Contributor Author

eoghanmurray commented Aug 11, 2023 •
edited
Loading

Checks are failing as I authored it with #1279 in place, so that should be considered a prerequisite of this
this is now rebased on top of master #1279

@Juice10
Copy link
Member

Juice10 commented Aug 11, 2023

@eoghanmurray could you rebase this PR, I just merged in #1279

@eoghanmurray
Perf: don't run the regex replace unless the selectorText contains a …
bb63703 
…colon (rules generally contain colons)
@eoghanmurray
Need to check type before querying selectorText property - also good …
aa8939d 
…as it means we only try to fix colons at the leaf level
Juice10
Juice10 reviewed Aug 14, 2023
View reviewed changes
@eoghanmurray eoghanmurray merged commit 64420c7 into rrweb-io:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Juice10 Juice10 Juice10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eoghanmurray @mydea @Juice10