Perf: Avoid creation of intermediary array when iterating over style rules#1272
Perf: Avoid creation of intermediary array when iterating over style rules#1272eoghanmurray merged 3 commits intorrweb-io:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 9c4c5fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1120c1f to
301a630
Compare
|
I'm happy to merge this once we have benchmarks running on CI |
|
@Juice10 If you plan on doing that in github actions just note that performance may vary quite a lot there. We (sentry) collect performance data and profiles from a lot of our CI runs and we see numbers vary about 30% for the same runners. |
|
@JonasBa I'm hoping we can do relative benchmarking (more info https://labs.quansight.org/blog/2021/08/github-actions-benchmarks ) to help with this. But it's definitely a valid concern. I'm not sure if there are any companies like https://buildjet.com that offer dedicated resources for benchmarking. |
@Juice10 yes, that is a good approach if you plan on using github's runners as your benchmarking infra. I would probably invest into seeing if it's possible to have an automated workflow that re-runs the benchmarks a few times so that they hopefully run on different runners - this could help improve the signal to noise ratio. |
…heet rules by using the second `mapFn` argument of Array.from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from
301a630 to
6ac581b
Compare
|
To note: MooTools versions less than 1.6 add an I don't know if we should guard against this similar to #1196 ... |
Discovered there's a second
mapFnargument of Array.fromhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from