Fix: Trigger mouse movement & hover with mouse up/down in sync mode#1191
Merged
Fix: Trigger mouse movement & hover with mouse up/down in sync mode#1191
Conversation
🦋 Changeset detectedLatest commit: b65163a The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
What if replayer is scrubbing/skipping over the hover/unhover — will many events get dispatched? |
Member
Author
Only one hover event will be applied on Flush once all events have been applied |
eoghanmurray
approved these changes
Mar 28, 2023
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger mouse movement and hover with mouse up and mouse down events when replayer.pause(...) is called.
Currently mouseUp/mouseDown wasn't triggering any mouse movement or hover in isSync (pause/seek) mode.