Fix: processed-node-manager is created even in the environment that doesn't need a recorder#1186
Merged
YunFeng0817 merged 2 commits intomasterfrom Mar 24, 2023
Merged
Fix: processed-node-manager is created even in the environment that doesn't need a recorder#1186YunFeng0817 merged 2 commits intomasterfrom
YunFeng0817 merged 2 commits intomasterfrom
Conversation
…oesn't need a recorder
🦋 Changeset detectedLatest commit: 5f4bd8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Juice10
reviewed
Mar 22, 2023
Member
Juice10
left a comment
There was a problem hiding this comment.
This is great, one things I'm afraid of now we've moved it to the record function is that we might get multiple ProcessedNodeManager raf loops if someone stops recording, and starts again. I think we should add it to the list of handlers that get switched off once recording stops.
End the RAF loop when the recorder stops
Juice10
approved these changes
Mar 24, 2023
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes:
In the built scripts, the new ProcessedNodeManager() statement is bundled into the global environment, which means it will be constructed whenever the script is loaded.
Currently, I'm trying to create a rrweb player page with the SSR (server-side render) and it doesn't have the RFA API on the server side. So it keeps throwing the error:
requestAnimationFrame isn't defined.