improve: some websites rebuild imcomplete#1163
Merged
YunFeng0817 merged 3 commits intorrweb-io:masterfrom Mar 13, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: 60f6c86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
YunFeng0817
reviewed
Mar 2, 2023
YunFeng0817
approved these changes
Mar 13, 2023
Member
YunFeng0817
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
This was referenced Mar 13, 2023
This was referenced Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #1118
Some websites, addedSet in emit function is not empty, but the result converted from Array.from is empty
Some websites polyfill classList functions of HTML elements. Their implementation may throw errors and cause the snapshot to fail. I add try-catch statements to make the code robust.