Skip to content

InheritedProvider v2#240

Merged
rrousselGit merged 20 commits into
v4.0.0from
inherited_provider_v2
Nov 23, 2019
Merged

InheritedProvider v2#240
rrousselGit merged 20 commits into
v4.0.0from
inherited_provider_v2

Conversation

@rrousselGit

@rrousselGit rrousselGit commented Oct 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Owner
  • InheritedProvider(value: ...) -> InheritedProvider.value(value: ...)
  • add default constructor with "valueBuilder" & "initialValueBuilder"
  • have both constructors expose a "listen" callback
  • update ChangeNotifierProvider/StreamProvider accordingly

@rrousselGit rrousselGit changed the title InheritedProvider -> InheritedProvider.value InheritedProvider v2 Oct 13, 2019
@rrousselGit rrousselGit force-pushed the inherited_provider_v2 branch from b7d9434 to 99e0942 Compare October 13, 2019 19:19
@rrousselGit rrousselGit changed the base branch from lazy to v4.0.0 October 13, 2019 19:19
@codecov-io

codecov-io commented Oct 13, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #240 into v4.0.0 will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v4.0.0     #240      +/-   ##
==========================================
+ Coverage    99.2%   99.43%   +0.23%     
==========================================
  Files          10       10              
  Lines         628      714      +86     
==========================================
+ Hits          623      710      +87     
+ Misses          5        4       -1
Impacted Files Coverage Δ
packages/provider/lib/src/selector.dart 100% <ø> (ø) ⬆️
packages/provider/lib/src/consumer.dart 100% <ø> (ø) ⬆️
packages/provider/lib/src/async_provider.dart 100% <100%> (ø) ⬆️
packages/provider/lib/src/inherited_provider.dart 100% <100%> (ø)
...es/provider/lib/src/value_listenable_provider.dart 100% <100%> (ø) ⬆️
packages/provider/example/lib/main.dart 91.11% <100%> (ø) ⬆️
...ges/provider/lib/src/change_notifier_provider.dart 100% <100%> (ø) ⬆️
packages/provider/lib/src/provider.dart 100% <100%> (ø) ⬆️
packages/provider/lib/src/listenable_provider.dart 100% <100%> (ø) ⬆️
packages/provider/lib/src/proxy_provider.dart 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d866a2...52ec246. Read the comment docs.

@rrousselGit rrousselGit mentioned this pull request Nov 12, 2019
Closed
@rrousselGit rrousselGit mentioned this pull request Nov 21, 2019
Closed
6 tasks
@rrousselGit rrousselGit marked this pull request as ready for review November 23, 2019 09:16
@rrousselGit rrousselGit merged commit 13cebb0 into v4.0.0 Nov 23, 2019
@rrousselGit rrousselGit deleted the inherited_provider_v2 branch December 22, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rrousselGit @codecov-io