Avoid deprecation warnings on redis-py 3.5.0 hmset#1253
Merged
Conversation
bbayles
commented
May 15, 2020
| def hmset(pipe_or_connection, name, mapping): | ||
| # redis-py versions 3.5.0 and above accept a mapping parameter for hset | ||
| try: | ||
| return pipe_or_connection.hset(name, mapping=mapping) |
Contributor
Author
There was a problem hiding this comment.
This signature for hset changed in redis-py 3.5.0, so this will immediately raise a TypeError if it's wrong.
Contributor
Author
There was a problem hiding this comment.
An alternative would be to check redis.__version__.
Codecov Report
@@ Coverage Diff @@
## master #1253 +/- ##
=======================================
Coverage 93.83% 93.83%
=======================================
Files 22 22
Lines 2319 2319
=======================================
Hits 2176 2176
Misses 143 143
Continue to review full report at Codecov.
|
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #1244, this PR adds an
hmsetfunction to the compatibility module such thathsetis preferred overhmsetwhen runningredis-py3.5.0+.