Skip to content

[WIP] ROWY-704: Feat formula field#949

Merged
shamsmosowi merged 16 commits intodevelopfrom
feat/formula-field
Dec 26, 2022
Merged

[WIP] ROWY-704: Feat formula field#949
shamsmosowi merged 16 commits intodevelopfrom
feat/formula-field

Conversation

@htuerker
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Nov 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
rowy-os ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 26, 2022 at 8:41PM (UTC)
rowy-typedoc ✅ Ready (Inspect) Visit Preview Dec 26, 2022 at 8:41PM (UTC)

@htuerker htuerker changed the title [WIP] Feat: Formula field [WIP] ROWY-704: Feat formula field Nov 15, 2022
@shamsmosowi
Copy link
Contributor

Screen Shot 2022-11-18 at 12 29 55 pm

hey @htuerker , 1) can we bring back the `row` class here? classes are more likely cause conflicts if they're top level 2) does listener field improve performance?

@shamsmosowi
Copy link
Contributor

Screen.Recording.2022-12-20.at.7.22.20.pm.mov

export const listenerFieldTypes = Object.values(FieldType).filter(
(type) =>
![
FieldType.action,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should only exclude last and subtable types, others should still be valid listener types as they do store values

}
`;

export const getDisplayCell = (type: FieldType) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this function necessary? Can we use the same implementation as the derivative type? as this can cause issues in the future when adding new columns

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that first but that way there's no easy workaround to disable firestore sync because UI is highly coupled with logic.

For the preview table feature, I will consider this as well regarding separate database logic from UI.

fieldTypesAction: "/field-types/action",
fieldTypesAdd: "/field-types/add",

fieldTypesFormula: "/field-types/formula",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have PR for Docs? @BeeBombshell can help this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll inform @BeeBombshell about it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shamsmosowi sure, I'll catch up with @htuerker for this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants