Changed default Action to script from cloud func#913
Merged
notsidney merged 3 commits intorowyio:developfrom Nov 16, 2022
mshamsrainey:action-field-default
Merged
Changed default Action to script from cloud func#913notsidney merged 3 commits intorowyio:developfrom mshamsrainey:action-field-default
notsidney merged 3 commits intorowyio:developfrom
mshamsrainey:action-field-default
Conversation
|
@mshamsrainey is attempting to deploy a commit to the Rowy Team on Vercel. A member of the Team first needs to authorize it. |
notsidney
suggested changes
Nov 9, 2022
Contributor
notsidney
left a comment
There was a problem hiding this comment.
Hi @mshamsrainey, you can’t change fields stored in the config without breaking backwards compatibility for some users. In this case, if they had clicked the “Cloud Function” radio button, it would have set config.isActionScript to false. Then, after this change, config.isCloudFunction would be undefined, so it displays the script options.
Currently, if config.isActionScript is falsy (false or undefined), it defaults to showing the Cloud Function options. You can alternatively check if it was explicitly set to false, so the default value, undefined, displays the script options.
Co-authored-by: Sidney Alcantara <sidney@sidney.me>
notsidney
approved these changes
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the settings for the Action field to default to a user-declared script instead of a cloud function that they've already deployed to Firestore/GCP.