#523: Added functional color field filtering#894
Merged
notsidney merged 4 commits intorowyio:developfrom Nov 2, 2022
mshamsrainey:enhancement/513-color-filter
Merged
#523: Added functional color field filtering#894notsidney merged 4 commits intorowyio:developfrom mshamsrainey:enhancement/513-color-filter
notsidney merged 4 commits intorowyio:developfrom
mshamsrainey:enhancement/513-color-filter
Conversation
|
@mshamsrainey is attempting to deploy a commit to the Rowy Team on Vercel. A member of the Team first needs to authorize it. |
notsidney
suggested changes
Oct 27, 2022
Contributor
notsidney
left a comment
There was a problem hiding this comment.
This is a good start but unfortunately there’s an issue with how we store colors. The HSV values in Firestore aren’t integers, and when selecting a color using HEX or RGB, the decimal values can be different, so the filters don’t work, since it compares the whole object.
You can write a custom filter here @src/hooks/useFirestoreCollectionWithAtom.ts to only compare the .hex values
Contributor
Author
|
Appreciate the feedback @notsidney! Just added another commit that should address your suggestion and also make a tweak to how the color field filter values are formatted, let me know what you think :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if the UI on this is quite what y'all are looking for, but wanted to go ahead and get the PR up for feedback!