The latest updates on your projects. Learn more about Vercel for Git ↗︎

@nithinrdy is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

Just wondering -- anything else I'd need to do before/while the PR is in review?

Thank you for the PR. The PR works but I feel it can be done in a better way.

In its current form, we can't set size through the keyboard because it uses the mouse event. Another point - calling setTableHeaders on every render doesn't feel right.

I propose that we use table.setColumnSizing function to resize. To access table in setColumnWidthModal we can store it in an atom. Let me explain it with code.

Table.tsx

const [reactTable, setReactTable] = useAtom(reactTableAtom, tableScope)
const table = useReactTable({})
useMemo(() => {
  setReactTable(table)
}, [table])

setColumnWidthModal.tsx

export default function SetColumnWidthModal({ close }) {
  const [column] = useAtom(columnMenuAtom, tableScope)
  const [table] = useAtom(reactTableAtom, tableScope)
  const onSubmit = (e) => {
    table.setColumnSizing((old) => {
      return {
        ...old,
        [column.name]: e.target.value
      }
    }
  }
  
  return <></>
}

Having react table in an atom should be useful in the future too. What do you think about this approach?