Skip to content

Reorder image file field#1112

Merged
shamsmosowi merged 6 commits intorowyio:developfrom
saravanan-inc:reorderImageFileField
Feb 22, 2023
Merged

Reorder image file field#1112
shamsmosowi merged 6 commits intorowyio:developfrom
saravanan-inc:reorderImageFileField

Conversation

@saravanan-inc
Copy link
Contributor

@saravanan-inc saravanan-inc commented Feb 8, 2023

No description provided.

@vercel
Copy link

vercel bot commented Feb 8, 2023

Someone is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Feb 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
rowy-os ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 22, 2023 at 7:24AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
rowy-typedoc ⬜️ Ignored (Inspect) Feb 22, 2023 at 7:24AM (UTC)

@shamsmosowi shamsmosowi self-requested a review February 17, 2023 06:15
shamsmosowi
shamsmosowi suggested changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@shamsmosowi shamsmosowi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saravanan-inc thank you for the contribution,this looks great!
two things to improve on would be:

  • add support for reordering in the sidedrawer
  • hide the drag and drop icon when there's only one image in the cell, to save on space

@saravanan-inc
Copy link
Contributor Author

saravanan-inc commented Feb 18, 2023

Hi @shamsmosowi thanks for updating on this issue and the bug,

Added support for reordering the both the image and file fields in the SideDrawer
Add hide the image and file fields drag option if there is only one file or one image

@shamsmosowi
Copy link
Contributor

shamsmosowi commented Feb 22, 2023

Hi @shamsmosowi thanks for updating on this issue and the bug,

Added support for reordering the both the image and file fields in the SideDrawer Add hide the image and file fields drag option if there is only one file or one image

Perfect! Thank you @saravanan-inc !

@shamsmosowi shamsmosowi merged commit eee88d9 into rowyio:develop Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shamsmosowi shamsmosowi shamsmosowi requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saravanan-inc @shamsmosowi