Skip to content

ROWY-831: Add preview table#1056

Merged
shamsmosowi merged 3 commits intodevelopfrom
ROWY-831-preview-table
Feb 15, 2023
Merged

ROWY-831: Add preview table#1056
shamsmosowi merged 3 commits intodevelopfrom
ROWY-831-preview-table

Conversation

@htuerker
Copy link
Contributor

@htuerker htuerker commented Jan 5, 2023

No description provided.

@vercel
Copy link

vercel bot commented Jan 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
rowy-os ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 2:34PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
rowy-typedoc ⬜️ Ignored (Inspect) Feb 15, 2023 at 2:34PM (UTC)

@shamsmosowi
Copy link
Contributor

shamsmosowi commented Jan 5, 2023

Works perfectly!
Are we able to hide the following table features from the preview mode

  • the drop-down for different add row types can be restricted to add to the top only
  • DnD column headers
  • sorting column button
  • column settings button
  • row menu button
Screen.Recording.2023-01-05.at.1.41.00.pm.mov

@htuerker
Copy link
Contributor Author

htuerker commented Jan 17, 2023

Works perfectly! Are we able to hide the following table features from the preview mode

  • the drop-down for different add row types can be restricted to add to the top only
  • DnD column headers
  • sorting column button
  • column settings button
  • row menu button

Screen.Recording.2023-01-05.at.1.41.00.pm.mov

<Box
sx={{
maxHeight: 300,
overflow: "auto",
marginTop: 1,
marginLeft: 0,
// tableToolbar
"& > div:first-child > *:not(:first-child)": {
display: "none",
},
// table grid
"& > div:nth-child(2)": {
height: "unset",
},
// emtpy state
"& .empty-state": {
display: "none",
},
// column actions - add column
'& [data-col-id="_rowy_column_actions"]': {
padding: 0,
width: 0,
},
'& [data-col-id="_rowy_column_actions"] > button': {
display: "none",
},
}}
>

There're already some hidden parts. For now, it's good to use CSS to hide things in the Table view. But later on, we may want to build a generalized solution such as using toolset variable: ["filters", "row_actions", "column_settings"]

@shamsmosowi
Copy link
Contributor

Works perfectly! Are we able to hide the following table features from the preview mode

  • the drop-down for different add row types can be restricted to add to the top only
  • DnD column headers
  • sorting column button
  • column settings button
  • row menu button

Screen.Recording.2023-01-05.at.1.41.00.pm.mov

<Box
sx={{
maxHeight: 300,
overflow: "auto",
marginTop: 1,
marginLeft: 0,
// tableToolbar
"& > div:first-child > *:not(:first-child)": {
display: "none",
},
// table grid
"& > div:nth-child(2)": {
height: "unset",
},
// emtpy state
"& .empty-state": {
display: "none",
},
// column actions - add column
'& [data-col-id="_rowy_column_actions"]': {
padding: 0,
width: 0,
},
'& [data-col-id="_rowy_column_actions"] > button': {
display: "none",
},
}}
>

There're already some hidden parts. For now, it's good to use CSS to hide things in the Table view. But later on, we may want to build a generalized solution such as using toolset variable: ["filters", "row_actions", "column_settings"]
yep, that's fine lets hide the rest with css as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants