Skip to content

ROWY-844 Feat: Import JSON#1042

Merged
shamsmosowi merged 3 commits intorowyio:developfrom
iamanishroy:feat-import-json
Dec 31, 2022
Merged

ROWY-844 Feat: Import JSON#1042
shamsmosowi merged 3 commits intorowyio:developfrom
iamanishroy:feat-import-json

Conversation

@iamanishroy
Copy link
Member

@iamanishroy iamanishroy commented Dec 30, 2022

image

High Level Flow

Accept JSON -> convert JSON to CSV -> parse CSV

@vercel
Copy link

vercel bot commented Dec 30, 2022

@iamanishroy is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 30, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
rowy-os ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 31, 2022 at 5:11AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
rowy-typedoc ⬜️ Ignored (Inspect) Dec 31, 2022 at 5:11AM (UTC)

@shamsmosowi shamsmosowi self-requested a review December 30, 2022 09:38
shamsmosowi
shamsmosowi suggested changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@shamsmosowi shamsmosowi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like the idea of converting json to csv before processing it, however it looks like its having issues detecting some types, like here its picking up a json array as url type
Screenshot 2022-12-30 at 10 31 54 am

@iamanishroy
Copy link
Member Author

iamanishroy commented Dec 30, 2022 •
edited
Loading

Looks like this problem persists when we import from CSV also. So, I believe a new issue can be opened for the fix.

image

@shamsmosowi
Copy link
Contributor

shamsmosowi commented Dec 30, 2022 •
edited
Loading

Looks like this problem persists when we import from CSV also. So, I believe a new issue can be opened for the fix.

image

You're right, looks like its not causing it, we can look into this separately, I think @mshamsrainey might be working on something related already

@shamsmosowi shamsmosowi merged commit 4264e24 into rowyio:develop Dec 31, 2022
@iamanishroy iamanishroy deleted the feat-import-json branch January 2, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shamsmosowi shamsmosowi shamsmosowi requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iamanishroy @shamsmosowi