ROWY-816 Fix: Small blip in the ordering columns#1023
ROWY-816 Fix: Small blip in the ordering columns#1023shamsmosowi merged 13 commits intorowyio:developfrom
Conversation
|
@iamanishroy is attempting to deploy a commit to the Rowy Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
|
||
| // This is where we update the documents | ||
| const handleSubmit = () => { | ||
| const handleSubmit = async () => { |
There was a problem hiding this comment.
This part looks good. However, it should have been a separate PR. it's okay for now, but for the future, since its a separate issue
|
|
||
| const updateColumn = useSetAtom(updateColumnAtom, tableScope); | ||
|
|
||
| // function to revalidate quickAccessTableColumnsOrdered |
There was a problem hiding this comment.
Screen.Recording.2022-12-27.at.1.05.31.pm.mov
While this solution works for reordering items on the hidden columns UI, it doesn't solve the same issue occurring on the table DnD interaction, it also adds unnecessary computation of reordering that's already being handled by the updateColumn atom, I think an ideal solution would be to implement optimistic updates in the useFirestoreDocWithAtom and solve all similar issues
There was a problem hiding this comment.
As suggested, I worked on it.
Issue
Fix
And the final result.