Skip to content

Reorder Select, MultiSelect field 515#1012

Merged
shamsmosowi merged 2 commits intorowyio:developfrom
saravanan-inc:reorderSelectMultiSelectField_515
Jan 16, 2023
Merged

Reorder Select, MultiSelect field 515#1012
shamsmosowi merged 2 commits intorowyio:developfrom
saravanan-inc:reorderSelectMultiSelectField_515

Conversation

@saravanan-inc
Copy link
Contributor

Add Reorder Select and Multi-select Field using react-dnd

@vercel
Copy link

vercel bot commented Dec 13, 2022

@saravanan-inc is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
rowy-os ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 15, 2023 at 9:26AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
rowy-typedoc ⬜️ Ignored (Inspect) Jan 15, 2023 at 9:26AM (UTC)

@saravanan-inc saravanan-inc changed the title Reorder select multi select field 515 Reorder Select, MultiSelect field 515 Dec 13, 2022
@harinij harinij requested a review from shamsmosowi December 21, 2022 01:58
Copy link
Contributor

@shamsmosowi shamsmosowi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saravanan-inc, thanks for the contribution
the reordering is functional, however to improve it and make it intuitive to users, you can look into the dnd implementation by @iamanishroy, interms of both the icon to the left and the animation during the interaction

Screen.Recording.2022-12-21.at.7.29.24.am.mov

let me know if you need an further clarification

@harinij
Copy link
Member

harinij commented Jan 6, 2023

Hi @saravanan-inc 👋 thanks for working on the feedback, just checking if you need any additional inputs and if there is any update.

@saravanan-inc
Copy link
Contributor Author

saravanan-inc commented Jan 7, 2023

Hi @saravanan-inc 👋 thanks for working on the feedback, just checking if you need any additional inputs and if there is any update.

@harinij updated the code 👍

@saravanan-inc saravanan-inc force-pushed the reorderSelectMultiSelectField_515 branch from 30ef8f1 to b34add1 Compare January 15, 2023 09:26
Copy link
Contributor

@shamsmosowi shamsmosowi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👍

@shamsmosowi shamsmosowi merged commit 507304d into rowyio:develop Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants