Merged
Conversation
# Conflicts: # src/components/fields/types.ts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…action/default value/connector)
shamsmosowi
suggested changes
Dec 29, 2022
Contributor
shamsmosowi
left a comment
There was a problem hiding this comment.
just the logging defs needs to be cleaned everything else LGTM
| auth: firebaseauth.BaseAuth; | ||
| query: string; | ||
| user: ConnectorUser; | ||
| logging: { |
Contributor
There was a problem hiding this comment.
I see this block repeated for each .d.ts, Can we create something like RowyLogger Type and use it instead having to define each function
Contributor
Author
There was a problem hiding this comment.
@shamsmosowi I have updated the code to reuse logging types.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements experimental Rowy Logging feature. Rowy Logging enables a better logging experience across Rowy.
logging.log()is provided to all code editors and the logs can be queried directly in Rowy with multiple filters.An example usage of
logging.log()Logs are easy to access across Rowy. In Extensions or Webhooks, user can click on logs icon to see logs specific to that Extension/Webhook:
User can also see logs specific to a column by clicking on the logs icon in column settings.
Rowy Logs Explorer provides multiple filters:
Backend codes are already in develop branches:
https://github.com/rowyio/rowy-hooks/tree/develop
https://github.com/rowyio/backend/tree/develop
Rowy Logging is a complex feature. There are a lot to implement. We should continuously optimise functionalities of Rowy Logging, besides whats available in this PR which provides some basic usages.