Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to migrate rowy from CRA to Vite and facing a problem due to this package. Currently this package tries to export both CJS and ESM but exports only CJS. Inside the CJS export, the package is using
requireto import lodash-es which is an ESM module. This is causing an error when building the project with Vite.A solution will be to use
resolve.aliasto maplodash-estolodash. This will not only map imports ofform-builderbutrowytoo. Since, rowy is to be built using Vite and Vite uses ES modules we want to uselodash-esin rowy and notlodash.My proposal is to make this package export as an ES module and then we won't have to map
lodash-es.I have updated use-debounce because they implemented a fix for ES modules. I have updated react-hook-form so that the react-hook-form of
form-builderandrowyare same. I was getting a typescript error in rowy without it.I have tested this PR along with rowio/rowy#1279