Merged
Conversation
Owner
|
Thanks @mfedderly ! Published as 1.4.0 |
twelch
reviewed
Mar 21, 2022
Comment on lines
+5
to
+6
| export default function sweeplineIntersections( | ||
| geojson: FeatureCollection<GeometryObject> | Feature<GeometryObject>, |
There was a problem hiding this comment.
@mfedderly perhaps you had reasons, but should geojson param also accept GeometryObject, not just Feature and FeatureCollection. Also it's not all GeometryObject types according to the docs?, just LineString | MultiLineString | Polygon | MultiPolygon. So the signature would be something like:
geojson: FeatureCollection<LineString | MultiLineString | Polygon | MultiPolygon> | Feature<LineString | MultiLineString | Polygon | MultiPolygon> | LineString | MultiLineString | Polygon | MultiPolygon
See docs:
"Valid inputs: Geojson Feature or Geometry including Polygon, LineString, MultiPolygon, MultiLineString, as well as FeatureCollection."
There was a problem hiding this comment.
The second argument ignoreSelfIntersection also should be optional according to the docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.