Added support for arrays for smtp_user and smtp_pass config options#10083
Merged
alecpl merged 2 commits intoroundcube:masterfrom Mar 29, 2026
Merged
Added support for arrays for smtp_user and smtp_pass config options#10083alecpl merged 2 commits intoroundcube:masterfrom
alecpl merged 2 commits intoroundcube:masterfrom
Conversation
alecpl
requested changes
Mar 22, 2026
The initial PR broke the possibility to pass empty strings to the connect function for $user and $pass to effectively disable authentication. The updated PR now also allows this and only uses the configuration values of $user and $pass (including support for arrays) if they were not passed as parameters to the connect function - same as the original code did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Roundcube 1.6 the possibility was added to have more than one SMTP host, i.e. define an array of SMTP hosts, which get selected based on the IMAP host used for the logged in user. However, one could still only define a single smtp_user and smtp_pass or use the IMAP user and password (%u, %p) as credentials.
For many scenarios, this is not sufficient and therefore I added the same mechanism that is used to select the SMTP host based on the IMAP host to select the SMTP user and SMTP password both defined in arrays similar to SMTP host.