removing deprecated executeAsync function#3
Merged
rounak610 merged 3 commits intowdio_v9_fixesfrom Jan 28, 2025
Merged
Conversation
07souravkunda
suggested changes
Jan 24, 2025
| const fnBody = accessibilityScripts.saveTestResults || '' | ||
| const arg = dataForExtension | ||
| const results: unknown = await browser.execute( | ||
| `return (await function (...bstackSdkArgs) { |
There was a problem hiding this comment.
await needs to be removed right?
Owner
Author
There was a problem hiding this comment.
have fixed this, plz review again
07souravkunda
suggested changes
Jan 27, 2025
| const summaryResults: { [key: string]: unknown; } = await (browser as WebdriverIO.Browser).executeAsync(AccessibilityScripts.getResultsSummary as string) | ||
| const fnBody = AccessibilityScripts.getResultsSummary || '' | ||
| const summaryResults: { [key: string]: unknown; } = await browser.execute( | ||
| `return (function (...bstackSdkArgs) { |
There was a problem hiding this comment.
let's create a util method for this. DRY
Owner
Author
There was a problem hiding this comment.
have moved this repetitive code to a function in util.ts, plz review again
07souravkunda
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers