Merged
Conversation
kamal-kaur04
suggested changes
Jan 27, 2025
| PercyLogger.debug('Percy fetch token success: ' + response.token) | ||
| return response.token | ||
| } | ||
| this.percyCaptureMode = response.percy_capture_mode |
Owner
Author
There was a problem hiding this comment.
have fixed this, plz review again
| options = { | ||
| ...options, | ||
| testCase: name || '', | ||
| thTestCaseExecutionId: uuid || '', |
Owner
Author
There was a problem hiding this comment.
this was discussed with Ninad, he told me that Percy needs to change their data model to support different thTestCaseExecutionId & currenty they are not picking this up, thats why he suggested me to not send the id
ticket: https://browserstack.atlassian.net/browse/PER-4359
| BStackLogger.info(`Upload response: ${JSON.stringify(response, null, 2)}`) | ||
| BStackLogger.logToFile(`Response - ${format(response)}`, 'debug') | ||
| } | ||
| } catch (error) { |
There was a problem hiding this comment.
why adding try catch here if added in uploadLogs method?
Owner
Author
There was a problem hiding this comment.
have removed the try catch block
kamal-kaur04
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers