Skip to content

Fixes to support bidi#1

Merged
rounak610 merged 6 commits intowdio_v9_fixesfrom
fixes_to_support_bidi
Jan 28, 2025
Merged

Fixes to support bidi#1
rounak610 merged 6 commits intowdio_v9_fixesfrom
fixes_to_support_bidi

Conversation

@rounak610
Copy link
Owner

Proposed changes

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

level: 'debug'
}
})}`)
await (this._browser as WebdriverIO.Browser).executeScript(`browserstack_executor: {"action": "annotate", "arguments": {"data": "ObservabilitySync:${Date.now()}", "level": "debug"}}`, [])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing ??

${JSON.stringify({
                action: 'annotate',
                arguments: {
                    data: `ObservabilitySync:${Date.now()}`,
                    level: 'debug'
                }
            })}

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have fixed this, plz review again

@rounak610 rounak610 merged commit 5bee5c8 into wdio_v9_fixes Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants