Test impacted daily selection with source-only diff#9
Closed
roshkhatri wants to merge 6 commits into
Closed
Conversation
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
…er search When a set command like SADD receives an integer value and the set is listpack-encoded, the previous code converted the integer to a string to call lpFind(), which then converted it back to an integer internally. Add lpFindInteger() that accepts a long long directly and compares against integer-encoded listpack entries without any string conversion. Use it in setTypeAdd() when the value arrived as an integer (str == tmpbuf). Fixes valkey-io#3408 Signed-off-by: liveprasad <prasad.shetkar093@gmail.com> (cherry picked from commit 7d2e056)
This reverts commit 21d53d8.
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Exercise the PR-local impacted daily selector with a source-only diff.
Notes
unstablealready contains the workflow split intodaily-pr.yml.src/server.c.