Skip to content

Test impacted daily selection with source-only diff#9

Closed
roshkhatri wants to merge 6 commits into
unstablefrom
codex/test-impacted-daily-source-only
Closed

Test impacted daily selection with source-only diff#9
roshkhatri wants to merge 6 commits into
unstablefrom
codex/test-impacted-daily-source-only

Conversation

@roshkhatri

Copy link
Copy Markdown
Owner

Purpose

Exercise the PR-local impacted daily selector with a source-only diff.

Notes

  • Base branch unstable already contains the workflow split into daily-pr.yml.
  • This branch only changes src/server.c.
  • The change is a small refactor of duplicated SDS key comparison logic to make the selector run against a real code-path diff.

Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
liveprasad and others added 5 commits April 3, 2026 11:11
…er search

When a set command like SADD receives an integer value and the set is
listpack-encoded, the previous code converted the integer to a string to
call lpFind(), which then converted it back to an integer internally.

Add lpFindInteger() that accepts a long long directly and compares against
integer-encoded listpack entries without any string conversion. Use it in
setTypeAdd() when the value arrived as an integer (str == tmpbuf).

Fixes valkey-io#3408

Signed-off-by: liveprasad <prasad.shetkar093@gmail.com>
(cherry picked from commit 7d2e056)
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
Signed-off-by: Roshan Khatri <rvkhatri@amazon.com>
@roshkhatri roshkhatri closed this Apr 3, 2026
@roshkhatri roshkhatri deleted the codex/test-impacted-daily-source-only branch April 3, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants