Skip to content

moduleapi: preserve RedisModule_OnLoad export compatibility#5

Closed
roshkhatri wants to merge 1 commit into
unstablefrom
fix-fix-crashes-in-issues-#547,-#1921,-#2322,-#1256
Closed

moduleapi: preserve RedisModule_OnLoad export compatibility#5
roshkhatri wants to merge 1 commit into
unstablefrom
fix-fix-crashes-in-issues-#547,-#1921,-#2322,-#1256

Conversation

@roshkhatri

Copy link
Copy Markdown
Owner

Motivation

Description

  • Remove the #define RedisModule_OnLoad ValkeyModule_OnLoad macro from src/redismodule.h and add a comment explaining why the RedisModule_OnLoad entry-point must remain unmapped, while keeping server compatibility since valkey-server probes both ValkeyModule_OnLoad and RedisModule_OnLoad.

Testing

  • Ran a full build with make -j4, compiled a minimal module that exports RedisModule_OnLoad via -Wl,--version-script=..., started src/valkey-server and confirmed the server log shows Module 'hello' loaded, so the build and validation succeeded.

Codex Task

@roshkhatri roshkhatri removed the codex label Mar 18, 2026
@roshkhatri roshkhatri closed this Mar 18, 2026
@roshkhatri roshkhatri deleted the fix-fix-crashes-in-issues-#547,-#1921,-#2322,-#1256 branch March 18, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant