This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Merged
Conversation
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Author
|
CI (build:
|
clalancette
reviewed
Sep 15, 2020
clalancette
left a comment
There was a problem hiding this comment.
In principle, I agree with this change and would have approved it. But CI on Windows and macOS is failing to find TinyXML :(.
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Author
|
CI with commit using
|
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Author
|
CI with attempt at windows fix
|
Author
|
@clalancette CI LGTM! Mind giving this another look? |
clalancette
approved these changes
Sep 18, 2020
clalancette
left a comment
There was a problem hiding this comment.
Woohoo! Hopefully this unblocks some of the other URDF stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
urdfdomnot exporting a transitive dependency onurdfdom_headersin its exported targets. This makes the targets use CMake exported targets instead of old-style CMake variables.I also madeedit had to undo this because windowsurdf_worlddepend onurdf_model- beforeurdf_worldwas building all ofurdf_model's sources plusworld.cpp.more info here: ros2/urdf#17 (comment)