Skip to content

add package.xml#10

Merged
mikaelarguedas merged 1 commit intomasterfrom
add_package_xml
Jun 11, 2018
Merged

add package.xml#10
mikaelarguedas merged 1 commit intomasterfrom
add_package_xml

Conversation

@mikaelarguedas
Copy link
Copy Markdown
Member

@mikaelarguedas mikaelarguedas added the in review Waiting for review (Kanban column) label Jun 11, 2018
@mikaelarguedas mikaelarguedas self-assigned this Jun 11, 2018
@nuclearsandwich
Copy link
Copy Markdown
Member

@nuclearsandwich I removed the exported dependency on cmake to match what we do for tinyxml2

I think removing this is correct. If memory serves the reason I added it was because the vendor package runs cmake code at its run time (downstream build time) and so packages which depend on it require cmake to be in their build time dependencies.

But in order to try and avoid cmake at runtime I think it's permissible to assume that anything which depends on the vendor package rather than tinyxml2 directly already needs cmake at build time.

@mikaelarguedas mikaelarguedas merged commit b3d436d into master Jun 11, 2018
@mikaelarguedas mikaelarguedas deleted the add_package_xml branch June 11, 2018 16:34
@rohbotics rohbotics removed the in review Waiting for review (Kanban column) label Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants