Merged
Conversation
83 tasks
Member
I think removing this is correct. If memory serves the reason I added it was because the vendor package runs cmake code at its run time (downstream build time) and so packages which depend on it require cmake to be in their build time dependencies. But in order to try and avoid cmake at runtime I think it's permissible to assume that anything which depends on the vendor package rather than tinyxml2 directly already needs cmake at build time. |
nuclearsandwich
approved these changes
Jun 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from https://github.com/ros2-gbp/tinyxml_vendor-release/blob/a0cd47f63740eb8d37d2d2615721537605976250/xenial/package.xml
@nuclearsandwich I removed the exported dependency on
cmaketo match what we do for tinyxml2