Use rcpputils/scope_exit.hpp instead of rclcpp/scope_exit.hpp#479
Merged
clalancette merged 1 commit intoros2:masterfrom Jul 23, 2021
Merged
Conversation
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
clalancette
approved these changes
Jul 23, 2021
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Seems totally reasonable to me; these packages were already indirectly dependent on rcpputils, so we are now just making them directly dependent. As long as CI is green, thumbs up from me.
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See ros2/rclcpp#1725
This has to be merged before the header can be removed from
rclcpp.Signed-off-by: Christophe Bedard bedard.christophe@gmail.com