Merged
Conversation
* Add parameters service tests for failures due to undeclared parameters * Refactor parameter test fixtures Renamed functions for consistency and reduced code-smell Signed-off-by: Jacob Perron <jacob@openrobotics.org>
57b1da7 to
f2ea433
Compare
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
Edit: "TimeSource" test failures are known issues on master |
wjwwood
approved these changes
May 15, 2019
Member
Author
|
It looks like the test times out on macOS and Windows, but I noticed that the same timeout happened in the macOS nightly (ros2/build_farmer#198). It's possible the test is flaky and this addition may make it worse. It's probably why I needed to increase the shutdown timeout (which appears to fix things for Linux). @wjwwood If it is okay with you, I will merge this and we can follow up with looking into the macOS and Windows failures as part of ros2/build_farmer#198. |
Member
|
Fine with me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ros2/rclcpp#705
In particular, added tests for attempting to set undeclared parameters.