Disable any cross-vendor communication tests for Fast-RTPS.#322
Merged
Disable any cross-vendor communication tests for Fast-RTPS.#322
Conversation
Builds are actually failing for all cross-vendor tests involving rmw_fastrtps_cpp not just those between Connext and Fast-RTPS.
Member
Author
|
test_communication with all RMW vendors enabled: |
sloretz
approved these changes
Dec 14, 2018
Contributor
|
Linter passes locally with 323e45d. Merging |
dirk-thomas
reviewed
Jul 18, 2019
| (rmw_implementation1_is_connext AND rmw_implementation2_is_fastrtps) OR | ||
| (rmw_implementation1_is_fastrtps AND rmw_implementation2_is_connext)) | ||
| ) | ||
| if(WIN32 AND (rmw_implementation1_is_fastrtps OR rmw_implementation2_is_fastrtps)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds are actually failing for all cross-vendor tests involving rmw_fastrtps_cpp not just those between Connext and Fast-RTPS.