disable cross vendor tests for pub/sub fastrtps/connext#320
Merged
nuclearsandwich merged 2 commits intomasterfrom Dec 13, 2018
Merged
disable cross vendor tests for pub/sub fastrtps/connext#320nuclearsandwich merged 2 commits intomasterfrom
nuclearsandwich merged 2 commits intomasterfrom
Conversation
Signed-off-by: William Woodall <william@osrfoundation.org>
dirk-thomas
previously approved these changes
Dec 13, 2018
Member
|
Member
|
This might be implemented and I am not reading it correctly. Does it make sense to scope this skip to just Windows so that we continue to cover this on other platforms? |
Reducing the change to Windows only makes a lot of sense
Member
Author
|
522132c lgtm |
Member
|
Aborted the last CI run to try 522132c
Windows failure was due to infrastructure issue. Here is a retest: |
nuclearsandwich
approved these changes
Dec 13, 2018
Member
nuclearsandwich
left a comment
There was a problem hiding this comment.
LGTM with greenish CI (there's a waitable test on Windows that might still be unstable)
dirk-thomas
approved these changes
Dec 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just temporarily for the Crystal release until we can figure out why they no longer communicate.