Test parameter behavior for rclpy nodes#293
Conversation
First round of CI. There's a supplemental repos file that includes the necessary rclpy branch. |
|
|
||
| # Execute python files using same python used to start this test | ||
| if command[0][-3:] == '.py': | ||
| self._command = list(self._command) |
There was a problem hiding this comment.
This was needed because the tuples that get passed as commands are immutable.
sloretz
left a comment
There was a problem hiding this comment.
CI failures look like they are due to missing commits from master branch on rclpy. LGTM assuming next CI is green.
test_cli/CMakeLists.txt
Outdated
| PYTHON_EXECUTABLE "${_PYTHON_EXECUTABLE}" | ||
| ENV | ||
| INITIAL_PARAMS_RCLCPP=$<TARGET_FILE:initial_params_rclcpp> | ||
| INITIAL_PARAMS_RCLPY=test/initial_params.py |
There was a problem hiding this comment.
I'm not sure what I would have expected the working directory to be when the test is run. If this passes I guess that means it is the top level source directory containing CMakeLists.txt.
There was a problem hiding this comment.
We'll see how it fares in CI. At the very least it #worksonmymachine.
There was a problem hiding this comment.
But I think it's also reasonable to set the source directory either via CMAKE_CURRENT_LIST_DIR or some other preferred variable for source paths.
|
|
Testing again using CMAKE_CURRENT_LIST_DIR to get the absolute source directory path rather than leaving it to the chance of the current directory.
|
Adds an rclpy node to the test fixtures so that our tests cover both client libraries.
For these tests to succeed they must be run along with ros2/rclpy#225
Connects to ros2/rclpy#202