account for null-terminator character#269
Merged
mikaelarguedas merged 2 commits intomasterfrom May 8, 2018
Merged
Conversation
wjwwood
approved these changes
May 8, 2018
Member
|
Based on the data type |
Member
Author
|
Because we know the value of I'm not aware of a macro returning the maximum length of a string representation of a type, (but if there's one I'm more than happy to use it!). Does that match your suggestion? |
Member
|
That sounds better to me 👍 |
dirk-thomas
approved these changes
May 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a gcc warning as the string to store can be up to 4 numeric characters + the null-terminator so the container should be of size 5.
related to ros2/ros2#481