Place RTI OpenSSL on the (LD_LIBRARY_)PATH on Linux#263
Place RTI OpenSSL on the (LD_LIBRARY_)PATH on Linux#263mikaelarguedas merged 7 commits intomasterfrom
Conversation
2fa5d34 to
17373e2
Compare
|
This is broken on windows, moving back to "in progress" for now
Bionic: |
Rebased and modify logic to pass the build on windows
just pass unchanged PATH on other platforms Modify PATH only if connext is being tested modify path for all connext tests (not sure why it worked before)
35f9fdd to
522d117
Compare
|
I changed this to modify the PATH only when testing Connext on Linux to make sure we still exercise OpenSSL 1.1 when using Fast-RTPS. CI with last changes:
|
dirk-thomas
left a comment
There was a problem hiding this comment.
Reading the patch I was confused about TEST_PATH_WITH_RTI_BIN assuming it would contain the extra bin for all rmw. Further down I see that it is only populated in the case of Connext. Maybe renaming the variable to something like TEST_PATH would avoid that confusion.
Anyway the patch looks fine to me.
Good point I didnt rename the variable after changing the logic: done in 6dbd610 |
This implements "option a" described in ros2/ros2#481 (comment) as option b was evaluated as not acceptable for users.
This also works on xenial as the env vars stay the same so it can be merged async from ros2/ci#148 (but there's not much incentive to merge it before)
Xenial job:
Bionic job:
connects to ros2/ros2#481